feat(cert_manager): bump chart to 1.15#4079
Merged
Merged
Conversation
13b0568 to
da32a5c
Compare
dfd8e8a to
fd0feda
Compare
Signed-off-by: Mohammed Naser <mnaser@vexxhost.com>
fd0feda to
28f6b99
Compare
Collaborator
|
Backport failed for Please cherry-pick the changes locally and resolve any conflicts. git fetch origin stable/2025.2
git worktree add -d .worktree/backport-4079-to-stable/2025.2 origin/stable/2025.2
cd .worktree/backport-4079-to-stable/2025.2
git switch --create backport-4079-to-stable/2025.2
git cherry-pick -x 4cce9a089330d6c5be2384b26de89f44c8508742 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
_atmosphere_images.cert_manager_helm_charttov1.15.5v1.15.5cert_manager_cliimage from Atmosphere and addcert_manager_startupapicheckfor the v1.15 chart pathcert_manager_image_startupapicheckdirectly into the cert-manager roleThe
cert-manager-ctlimage is removed becausecert-manager-ctl:v1.15.5does not exist and the v1.15 chart usescert-manager-startupapicheckinstead.Testing
git diff --checkrg -n "cert_manager_cli" roles/defaults/vars/main.yml roles/cert_manager/tasks/main.ymlreturned no matchesnix develop --command env CGO_ENABLED=0 go test ./roles/defaults -run TestImageHasPrefixnix develop --command crane digest ghcr.io/vexxhost/charts/cert-manager:v1.15.5nix develop --command crane digest quay.io/jetstack/cert-manager-controller:v1.15.5nix develop --command crane digest quay.io/jetstack/cert-manager-cainjector:v1.15.5nix develop --command crane digest quay.io/jetstack/cert-manager-webhook:v1.15.5nix develop --command crane digest quay.io/jetstack/cert-manager-acmesolver:v1.15.5nix develop --command crane digest quay.io/jetstack/cert-manager-startupapicheck:v1.15.5nix develop --command crane digest quay.io/jetstack/cert-manager-ctl:v1.15.5returned 404, confirming the CLI image should not be bumped or kept for this pathnix develop --command env PRE_COMMIT_HOME=/tmp/pre-commit-atmosphere-cert-manager pre-commit run end-of-file-fixer --files roles/defaults/vars/main.yml roles/cert_manager/tasks/main.yml releasenotes/notes/bump-cert-manager-1-15-c84015c603c8b2f3.yamlnix develop --command env PRE_COMMIT_HOME=/tmp/pre-commit-atmosphere-cert-manager pre-commit run trailing-whitespace --files roles/defaults/vars/main.yml roles/cert_manager/tasks/main.yml releasenotes/notes/bump-cert-manager-1-15-c84015c603c8b2f3.yamlnix develop --command env PRE_COMMIT_HOME=/tmp/pre-commit-atmosphere-cert-manager pre-commit run mixed-line-ending --files roles/defaults/vars/main.yml roles/cert_manager/tasks/main.yml releasenotes/notes/bump-cert-manager-1-15-c84015c603c8b2f3.yaml